Skip to content

feat: add middleware support for Flight calls #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NguyenHoangSon96 merged 7 commits into from
Feb 6, 2026
Merged

feat: add middleware support for Flight calls #196

NguyenHoangSon96 merged 7 commits into from
Feb 6, 2026

Conversation

@NguyenHoangSon96
Copy link
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented Feb 5, 2026 •
edited
Loading

Closes #

Proposed Changes

  • Allow the users to pass an array of middlewares to our Flight client.
  • Add test cases
  • Add example query with client middleware

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@NguyenHoangSon96 NguyenHoangSon96 added this to the 0.17.0 milestone Feb 5, 2026
@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Feb 5, 2026
@codecov
Copy link

codecov bot commented Feb 5, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.51%. Comparing base (56e2b13) to head (b0c2f3e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
+ Coverage   70.37%   70.51%   +0.14%     
==========================================
  Files          35       35              
  Lines        2356     2364       +8     
==========================================
+ Hits         1658     1667       +9     
+ Misses        698      697       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

alespour
alespour approved these changes Feb 5, 2026
View reviewed changes
Copy link
Contributor

@alespour alespour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python is not my thing but LGTM, had Codex checked it and it says GTG as well.

bednar
bednar requested changes Feb 5, 2026
View reviewed changes
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NguyenHoangSon96 thanks for the PR. Could you please also add an example showing how to use this?

@NguyenHoangSon96
Copy link
Contributor Author

NguyenHoangSon96 commented Feb 5, 2026

Hi @bednar
I already did it in Examples/query_with_middleware.py‎ file

bednar
bednar approved these changes Feb 6, 2026
View reviewed changes
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@NguyenHoangSon96 NguyenHoangSon96 merged commit f6d42a6 into main Feb 6, 2026
17 checks passed
@NguyenHoangSon96 NguyenHoangSon96 deleted the feat/support-middleware-query-client branch February 6, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bednar bednar bednar approved these changes

@alespour alespour alespour approved these changes

Assignees

@NguyenHoangSon96 NguyenHoangSon96

Labels

None yet

Projects

None yet

Milestone

0.17.0

Development

Successfully merging this pull request may close these issues.

3 participants

@NguyenHoangSon96 @bednar @alespour